-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tropopause pressure to the GEOS-Chem Classic "SatDiagn" collection #2410
Add tropopause pressure to the GEOS-Chem Classic "SatDiagn" collection #2410
Conversation
This rebase brings the "feature/trop-prs-in-satdiagn" branch (which contains an update by @eamarais to add tropopause pressure to the SatDiagn collection) into the "dev/no-diff-to-benchmark" branch atop PR #2399. The original update was based off version 14.1.0. This merge brings PR # ( , by @) into Signed-off-by: Bob Yantosca <[email protected]>
CHANGELOG.md - Added an note that we have added tropopause pressure to the satellite diagnostics (update from @eamarais) Signed-off-by: Bob Yantosca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
CodeDir : f4c3860 GEOS-Chem submod update: Merge PR #2399 (Add "alldiags" int tests)
MAPL : 231d53c Merge pull request #36 from geoschem/feature/improve_hflux_regridding
GMAO_Shared : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake : ad5deba Added ecbuild as a submodule of ESMA_cmake
gFTL-shared : 4b82492 Merge branch 'upstream_v1.5.0' into feature/v1.5.0
FMS : 259759d Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : af42462 Merge PR #8 (Add PLEadv diagnostic for offline advection in GCHP)
geos-chem : 7d3f442e7 Merge PR #2410 (Add Trop Pressure to SatDiagn collection)
HEMCO : e68ebae HEMCO 3.9.2 release
yaFyaml : 19afe50 Merge branch 'upstream_v1.0.4' into feature/v1.0.4
pFlogger : 2c4b724 Merge branch 'upstream_v1.9.1' into feature/v1.9.1
Cloud-J : 37a4ece Update release version number and date
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Number of execution tests: 12
Submitted as SLURM job: 42700165
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Also, all tests were zero-diff w/r/t PR #2399. |
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
CodeDir : f9d5fd6 GEOS-Chem submod update: Merge PR #2399 (Add "alldiags" int tests)
GEOS-Chem : 7d3f442e7 Merge PR #2410 (Add Trop Pressure to SatDiagn collection)
HEMCO : e68ebae HEMCO 3.9.2 release
Cloud-J : 37a4ece Update release version number and date
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Using 24 OpenMP threads
Number of execution tests: 30
Submitted as SLURM job: 42699315
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Also, all tests were zero-diff w/r/t PR #2399 except:
The "alldiags" integration test showed no differences in the restart file but showed differences in the KppDiags and ObsPack diagnostics. These are due to the updates in the chemistry mechanism, and are to be expected. |
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This is the companion PR to #2407. We have implemented the patch submitted by @eamarais to add the tropopause pressure field to the GEOS-Chem Classic "SatDiagn" History collection. We have rebased these updates atop PR #2399, as the original update was created in version 14.1.0.
Expected changes
This is a "zero-diff-to-benchmark" update. It only adds a new field to an existing diagnostic collection, and will not affect any scientific results.
Related Github Issue