Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PULL REQUEST] Add metal species in the offline simulation #511

Closed
wants to merge 1 commit into from

Conversation

junweilovexu
Copy link

Add metal species in the offline simulation. In species suffix: _F1 = bin1; _F2 = bin2; _C3=bin3; _C4 = bin4. Bin sizes are the same as dust bins

@msulprizio
Copy link
Contributor

The input.geos.txt file corresponding to this updates is attached here.

For other input file updates, see geoschem/geos-chem-unittest#26.

@msulprizio
Copy link
Contributor

Randall Martin suggests including this as an option to the Transport Tracers simulation or as a separate specialty simulation.

@msulprizio msulprizio self-assigned this Nov 24, 2020
@msulprizio msulprizio closed this Dec 8, 2020
@msulprizio msulprizio deleted the branch geoschem:main December 8, 2020 19:24
@msulprizio msulprizio reopened this Dec 8, 2020
@msulprizio msulprizio changed the base branch from master to main December 8, 2020 19:37
@yantosca yantosca changed the title Add metal species in the offline simulation [PULL REQUEST] Add metal species in the offline simulation Jan 13, 2021
@msulprizio msulprizio added the never stale Never label this issue as stale label Jan 25, 2021
@msulprizio msulprizio added this to the 13.2.0 milestone Feb 27, 2021
@msulprizio msulprizio added category: Feature Request New feature or request and removed never stale Never label this issue as stale labels Mar 3, 2021
@yantosca
Copy link
Contributor

Hi @junweilovexu (CC: @msulprizio), I am looking at this PR. I have a couple of questions:

  1. I noticed that some of the data files have data for each day of the year and each hour. Do we need the hourly resolution or is daily resolution OK? I am concerned that adding hourly data I/O to the TransportTracers simulation will slow down that simulation by a lot.
  2. I also noticed that the data files use double-precision for the data variables instead of single-precision. Can we change those to single precision? (I think that can be done with an one-liner: cdo -b f64 copy input.nc output.nc).

@yantosca
Copy link
Contributor

Also, it seems that in the http://rain.ucis.dal.ca/ctm/ForGCST/NATA folder, we only have a full year of data for the surface inventory, but not for the ptegu, ptonipm, and oilgas data files. I don't know if these files disappeared off the server of if they were never there. In any case, I will disable these emissions by default until further notice. We do have 365 days of the surface data, so I will use those. @junweilovexu @msulprizio

yantosca added a commit that referenced this pull request Jun 25, 2021
Following the Pull request:
#511

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca
Copy link
Contributor

yantosca commented Jul 1, 2021

This PR is now superseded by #769. We can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants