Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Bar Chart Widget on hover element to display accurate value #10716

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

weuceda14
Copy link

Description

Onhover element for bar charts was displaying wrong value for certain data. Recalculated how data is populated

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • [ x] Bugfix

Issue

What is the current behavior?

#

Barnhart on hover element displays wrong Y value sum for certain data

What is the new behavior?

recalculated how onhover element is populated so now it is accurate for all data types

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

… on the onhover element

Recalculated how the onHover element for the bar chart is populated. Would sometimes take the first entry y value instead of adding it up for certain types of data. Now the onhover displays the accurate number for all bar charts
Update WidgetChart.jsx so that the bar chart displays correct Y value…
@tdipisa
Copy link
Member

tdipisa commented Dec 5, 2024

@weuceda14 thank you so much for contributing to MapStore. We will review as soon as possible.

@offtherailz
Copy link
Member

Hi,
Looking at the PR, I'm not able to review these changes.
In order to help us review, can you please specify how to reproduce the issue, including your findings and the explaination of your solution?
Providing the data you used and that produced the issue you mention, or a way to reproduce it with standard data (e.g. us:states), screenshots or everything that can clarify the motivation of this PR, could be very useful to us.

Unit test that proves your fix could be also useful to better understand the logic behind your proposed change, and to prevent the fix from future regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants