Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFC request fails due to proxy issue #10694 #10745

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

rowheat02
Copy link
Contributor

@rowheat02 rowheat02 commented Jan 13, 2025

Description

The proxy test is common for all layers, the logic to recreate the layer if the test fails for Model layer was missing.
This PR fixes that missed logic for Model layer( #10694)

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

#10694

What is the current behavior?

#10694 - not calling through proxy after CORS test

What is the new behavior?

Model layer recreation after preflight test.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@rowheat02 rowheat02 self-assigned this Jan 13, 2025
@rowheat02 rowheat02 added the bug label Jan 13, 2025
@rowheat02 rowheat02 added this to the 2025.01.00 milestone Jan 13, 2025
@rowheat02 rowheat02 linked an issue Jan 13, 2025 that may be closed by this pull request
1 task
@rowheat02 rowheat02 marked this pull request as ready for review January 13, 2025 11:54
@tdipisa tdipisa requested a review from dsuren1 January 13, 2025 15:03
Copy link
Contributor

@dsuren1 dsuren1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsuren1 dsuren1 merged commit 78b7da3 into geosolutions-it:master Jan 15, 2025
6 checks passed
@tdipisa
Copy link
Member

tdipisa commented Jan 15, 2025

@ElenaGallo please test in DEV asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IFC request fails due to proxy issue
3 participants