Fix #10633 Enhancing MapViews Layer Options #10747
Open
+1,331
−460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
MV88
requested changes
Jan 14, 2025
| return true; | ||
| } | ||
| if (layer.type === 'vector') { | ||
| return !!layer?.features?.find(({ geometry }) => ['Polygon'].includes(geometry?.type)); |
There was a problem hiding this comment.
because the vector layer options are used to create clipping areas.
The only supported geometry for clipping areas is Polygon.
| </Section> | ||
| ); | ||
| } | ||
|
|
||
| LayersSection.contextTypes = { |
There was a problem hiding this comment.
what about LayersSection.propTypes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces following changes inside the layers section of the MapViews plugin:
there is also a fix related to 3DTiles to ensure the expected changes in the update are triggered when a tileset is loaded asynchronously
Screenshot showing the new layers section, including groups and search input with toolbar
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10633
What is the new behavior?
Refactor of the UI of layers sections inside the MapViews plugin including the concept of groups
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information