-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Implement PDF preview inside dashboards #9698
Fix: Implement PDF preview inside dashboards #9698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mumairr
Kindly amend these minor style issues. Thanks!
@@ -30,7 +30,7 @@ | |||
|
|||
|
|||
.ms-wizard { | |||
position: absolute; | |||
// position: absolute; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed. Kindly check and revert this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing styles for this one |
@mumairr |
right @dsuren1. I will keep it on hold |
Closing because has been solved here #9724 |
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Dashboards use React Quill Editor
What is the new behavior?
Implements Draftjs based editor for dashboards (Text) to allow embedding of any external link, document on the widget.
Fixes up scroll issue on widgets created from map
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
This PR is for backport based on version 2022.02.xx for use in GN. Same for the master has already been implemented last week,
https://github.com/geosolutions-it/C273-ISPRA-2023-UNEP-MAP/issues/42