Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements with OKTA OIDC provider integration #385

Merged
merged 5 commits into from
Nov 6, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,8 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.source>8</maven.compiler.source>
<maven.compiler.target>8</maven.compiler.target>
offtherailz marked this conversation as resolved.
Show resolved Hide resolved
</properties>

</project>
25 changes: 24 additions & 1 deletion src/modules/rest/impl/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,22 @@
<scope>test</scope>
</dependency>

<!-- JUnit 5 -->
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
<version>5.9.1</version>
<scope>test</scope>
</dependency>

<!-- Mockito for JUnit 5 -->
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-junit-jupiter</artifactId>
<version>4.8.0</version>
<scope>test</scope>
</dependency>

</dependencies>

<build>
Expand Down Expand Up @@ -288,8 +304,15 @@
</executions>
</plugin>
-->
<!-- Maven Surefire Plugin -->
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.0.0-M7</version>
<configuration>
<useModulePath>false</useModulePath>
</configuration>
</plugin>
</plugins>
</build>


</project>
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,9 @@ private SessionToken toSessionToken(String accessToken, UserSession sessionToken
@Override
public SessionToken refresh(SecurityContext sc, String sessionId, String refreshToken) {
String provider =
(String) RequestContextHolder.getRequestAttributes().getAttribute(PROVIDER_KEY, 0);
(String)
Objects.requireNonNull(RequestContextHolder.getRequestAttributes())
.getAttribute(PROVIDER_KEY, 0);
SessionServiceDelegate delegate = getDelegate(provider);
return delegate.refresh(refreshToken, sessionId);
}
Expand Down
Loading
Loading