-
Notifications
You must be signed in to change notification settings - Fork 344
0015 intellij refactoring dialog
nehashri edited this page Sep 25, 2017
·
1 revision
This ADR has been recorded retrospectively.
Accepted
In Intellij, invoking refactoring opens up a dialog. Since refactoring builds the project again, it takes sometime to see a success and failure message. If the refactoring fails, the new step text that was entered is not visible anymore
Discarded option to implement Inline refactoring as it is not easy to support this when inline step tables are present. Also, the success/fail message takes sometime to appear.
Change refactoring dialog to wait for build, and refactor to pass. If there are any errors show them on the dialog. Parse and validation errors should be shown to the user and they should be able to easily navigate to the error.
Copyright © ThoughtWorks Inc.