Small changes in response to PR comments

getodk · Nov 14, 2023 · f5abe29 · f5abe29
1 parent aeec6df
commit f5abe29
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/model/query/entities.js b/lib/model/query/entities.js
@@ -278,7 +278,7 @@ const _processSubmissionEvent = (event, parentEvent) => async ({ Datasets, Entit
   const dataset = (await Datasets.get(form.get().projectId, entityData.system.dataset, true))
     .orThrow(Problem.user.datasetNotFound({ datasetName: entityData.system.dataset }));
 
-  // Or update entity
+  // Try update before create (if both are specified)
   if (entityData.system.update === '1' || entityData.system.update === 'true')
     try {
       await Entities._updateEntity(dataset, entityData, submissionId, submissionDef, submissionDefId, event);

diff --git a/test/integration/api/entities.js b/test/integration/api/entities.js
@@ -2203,6 +2203,8 @@ describe('Entities API', () => {
           .expect(200)
           .then(({ body: logs }) => {
             logs[0].action.should.be.eql('entity.error');
+            logs[0].details.problem.problemCode.should.be.eql(400.2);
+            logs[0].details.errorMessage.should.be.eql('Required parameter label missing.')
             logs[1].action.should.be.eql('submission.create');
           });
       }));