Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e/s3: relax regex for failed connection #1341

Merged
merged 3 commits into from
Dec 10, 2024
Merged

test/e2e/s3: relax regex for failed connection #1341

merged 3 commits into from
Dec 10, 2024

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Dec 10, 2024 •
edited
Loading

Node 22 introduced deprecation warnings which changed the stderr output of lib/bin/s3.js, breaking a test assertion.

Related #1340
Closes #1339

lognaturel
lognaturel approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successful run at https://github.com/alxndrsn/odk-central-backend/actions/runs/12249690332/job/34171420425

alxndrsn added 2 commits December 10, 2024 05:35
@alxndrsn alxndrsn merged commit c9a3b65 into getodk:master Dec 10, 2024
1 check passed
@alxndrsn alxndrsn deleted the s3-e2e-regex-relax branch December 10, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lognaturel lognaturel lognaturel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 22 broke master
2 participants
@alxndrsn @lognaturel