Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runSequentially(): expand docs on current usage #1367

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

alxndrsn
Copy link
Contributor

The "current use" documentation does not cover all current uses.

Alternatively, this documentation could be removed completely, and intention for calling runSequentially() could be defined at the call sites.

What has been done to verify that this works as intended?

It's just a documentation change.

Why is this the best possible solution? Were any other approaches considered?

This documentation could be removed completely, and intention for calling runSequentially() could be defined at call sites.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does not affect users.

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

No.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

The "current use" documentation does not cover all current uses.

Alternatively, this documentation could be removed completely, and intention for calling runSequentially() could be defined at the call sites.
@alxndrsn alxndrsn requested review from sadiqkhoja and ktuite January 15, 2025 07:10
@alxndrsn alxndrsn merged commit e68ba1e into getodk:master Jan 15, 2025
6 checks passed
@alxndrsn alxndrsn deleted the run-sequentially-docs branch January 15, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants