db/unjoiner: remove extra sql`` wrapper #1374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2025 05:55
* simpler code * minor optimisation * resolves FIXME
alxndrsn
commented
Jan 17, 2025
| @@ -252,7 +252,7 @@ describe('util/db', () => { | |||
| it('should provide the appropriate arguments when extended', () => { | |||
| let run = false; | |||
| extender(T)(U)((fields, extend, options, x, y, z) => { | |||
| fields.should.eql(sql`"frames"."x" as "frames!x","frames"."y" as "frames!y","a" as "a","b" as "b"`); | |||
| sql`${fields}`.should.eql(sql`"frames"."x" as "frames!x","frames"."y" as "frames!y","a" as "a","b" as "b"`); | |||
There was a problem hiding this comment.
The alternative (no sql wrapper for fields) would make for a much less readable assertion:
{
"glue": {
"sql": ","
"type": Symbol(SLONIK_TOKEN_SQL)
"values": []
}
"members": [
{
"sql": "\"frames\".\"x\" as \"frames!x\""
"type": Symbol(SLONIK_TOKEN_SQL)
"values": []
}
{
"sql": "\"frames\".\"y\" as \"frames!y\""
"type": Symbol(SLONIK_TOKEN_SQL)
"values": []
}
{
"sql": "\"a\" as \"a\""
"type": Symbol(SLONIK_TOKEN_SQL)
"values": []
}
{
"sql": "\"b\" as \"b\""
"type": Symbol(SLONIK_TOKEN_SQL)
"values": []
}
]
"type": Symbol(SLONIK_TOKEN_LIST)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #1240, but not resolved before merge.
What has been done to verify that this works as intended?
CI
Why is this the best possible solution? Were any other approaches considered?
No other approaches were considered.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No effect.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
No.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes