update to latest wgpu-core #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realize now that I wasn't seeing checks for non-Linux code paths which introduced some errors I didn't catch. Will fix it all tomorrow. |
And a couple of formatting issues.
rajveermalviya
approved these changes
Nov 12, 2023
almarklein
approved these changes
Nov 13, 2023
|
(Sorry for the late merge, somehow this got left out.) After this is merged wgpu-native's trunk will target wgpu trunk, so any future changes would not be released until next major wgpu release, though we could backport some of them if possible to the v0.18 branch and make a dot release. |
|
wgpu-core 0.18.1 released yesterday, should we update to that in a new pr? Perhaps create a v0.18 branch? |
almarklein
approved these changes
Nov 16, 2023
Created #319, let's merge that one first then this one. |
|
Merging! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes version conflicts, updates the naga url to point to the main wgpu repo, some changes that arise from the bump to raw-window-handle 0.6.0. I am a Rust noob so please let me know if anything is amiss or bad style.