Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bioshd] fix fd_types #1777

Merged
merged 1 commit into from
Dec 24, 2023
Merged

[bioshd] fix fd_types #1777

merged 1 commit into from
Dec 24, 2023

Conversation

tyama501
Copy link
Contributor

Hello @ghaerr ,

This fix is for fd_type and the cyliner in
#1775

I think #ifdef CONFIG_ARCH_PC98 is better than #ifdef CONFIG_IMG_FD1232 since
1440 kernel for PC-98 can also read 1232 disk.

720KB for PC-98 enhancement will be coming on the next PR.

Thank you.

@ghaerr
Copy link
Owner

ghaerr commented Dec 24, 2023

I think #ifdef CONFIG_ARCH_PC98 is better than #ifdef CONFIG_IMG_FD1232 since
1440 kernel for PC-98 can also read 1232 disk.

Agreed, now that PC-98 may support multiple drive types simultaneously. There may be other similar cases that perhaps should be switched. In particular, IIRC, CONFIG_IMG_FD1232 is used to optimize the variable sector size code in the FAT filesystem, producing more code only when CONFIG_IMG_FD1232 is defined. Perhaps a future version of ELKS PC-98 should work for all FD sizes and CONFIG_IMG_FD1232 not be needed anymore?

Thank you!

@ghaerr ghaerr merged commit 2940102 into ghaerr:master Dec 24, 2023
1 check passed
@tyama501
Copy link
Contributor Author

Actually, ifdef for FD1232/FD1440 are still needed for boot code and the default value for the device address, for now,
since the boot sector is too small to detect and switch both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants