Adapt for use on multiple operating systems #7
Conversation
The params class uses facts to set tailored filenames and paths for the node. This is desireable in order to support multiple operating systems.
Not all operating systems store their default xinetd configuration file in /etc/xinetd.conf. Converting from a flat file to a template in order to support those operating systems.
|
The reason I'm submitting this pull request btw is that Portland State University (pdxcat) has a fork with extra functionality - the commits in this pull request - that we need for our Amanda Network Backup module. We'd much prefer to have that functionality in the original project (this one) and declare our amanda module's dependency to be on ghoneycutt/xinetd instead of on our fork, pdxcat/xinetd. It's your call on whether or not you think the commits are good ones and/or whether our fork has diverged too much to merge back in. Either way I appreciate your time in taking a look at it. :-) |
Make sure xinetd.d exists (not all OS packages automatically create such a file). Also rework init.pp order.
Add a bunch of extra xinetd::service parameters. Refactor a bit. Options that default to undef are not given a corresponding line in the xinetd service file, leaving their value to the xinetd default. Modified options: - bind = '0.0.0.0' + bind = undef New options: + access_times = undef + ensure = present + groups = 'yes' + log_on_failure = undef + log_type = undef + no_access = undef + only_from = undef + service_name = $title + xtype = undef
|
Fixed typo-induced bug wherein the File resource default set |
|
@ghoneycutt Any update on whether this will get merged? Should @marut submit it to puppetlabs/puppetlabs-xinetd instead? |
The attached commits make some pretty serious changes to the xinetd module in order to give it support for multiple operating systems and greater flexibility. Commit messages given below in roughly markdown format:
Add xinetd::params class
The params class uses facts to set tailored filenames and paths for the node. This is desireable in order to support multiple operating systems.
Convert files/xinetd.conf to a template
Not all operating systems store their default xinetd configuration file in /etc/xinetd.conf. Converting from a flat file to a template in order to support those operating systems.
Manage xinetd.d, rework init.pp
Make sure xinetd.d exists (not all OS packages automatically create such a file). Also rework init.pp order.
Expand xinetd::service options
Add a bunch of extra xinetd::service parameters. Refactor a bit. Options that default to undef are not given a corresponding line in the xinetd service file, leaving their value to the xinetd default.
Modified options:
New options: