Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min setup for initial commit #1

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Min setup for initial commit #1

wants to merge 12 commits into from

Conversation

chimp1984
Copy link
Collaborator

No description provided.

chimp1984 added 12 commits June 2, 2021 13:46
@chimp1984
Remove jfx-demos
7486eb6 
Add jfx module
@chimp1984
Strip down application module
5dffabd
@chimp1984
Strip down web module
ff01e51
@chimp1984
Remove api module
898046d 
Strip down grpc module

I think we do not need a dedicated api module but each domain comes with it's high level api (similar like the CoreApi in Bisq uses the other domain API classes)
@chimp1984
Strip down common
f1c4e23
@chimp1984
Strip down p2p
c340c6a
@chimp1984
Remove reactive module
fd2528c
@chimp1984
Remove wallet module
a308bf6 
I think we need a bit more concrete idea how we integrate the wallets. I assume we do not require dynamic loading for the start and just add the handful of supported wallet apis. But lets see once we get more concrete implementation code.
@chimp1984
remove obsolete dependencies
8d2546c 
Add resource dirs
@chimp1984
remove obsolete dependencies
b3cd1c9 
Add resource dirs
Fix package names
@chimp1984
Merge remote-tracking branch 'origin/min_setup_for_initial_commit' in…
a8b0afc 
…to min_setup_for_initial_commit
@chimp1984
Add logback files
875ddfa
ghubstan
ghubstan reviewed Jun 2, 2021
View reviewed changes
Copy link
Owner

@ghubstan ghubstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial commit needs a jfx module.

ghubstan
ghubstan reviewed Jun 2, 2021
View reviewed changes
Copy link
Owner

@ghubstan ghubstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want an empty common module? No code?

ghubstan
ghubstan reviewed Jun 2, 2021
View reviewed changes
Copy link
Owner

@ghubstan ghubstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: Include a p2p module in initial commit, with a bare P2PService class.

@chimp1984
Copy link
Collaborator Author

You want an empty common module? No code?

Might be the next PR after the initial ;-). Just wanted to be conservative with adding stuff until its 100% clear. For instance the Userthread I am not sure to use it that way again, maybe a variation....

@chimp1984
Copy link
Collaborator Author

Initial commit needs a jfx module.

Sorry seems I have remved too much ;-) . Yes should be part of initial commit.
Also a cli module might be added.
The other domain modules I would delegate for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubstan ghubstan ghubstan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chimp1984 @ghubstan