Only call tsconfig-glob if there is a filesGlob present in tsconfig.json #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any progress here? I'm waiting for this pull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mostly use this task to simply run tsc from grunt on my project. Nowadays tsc can scan subfolders for all .ts files so glob is not always needed. One can use "exclude" property in tsconfig.json and not specify "files" property and tsc will pick up all .ts files for building. Unfortunately tsconfig-glob package will write an empty "files" property in tsconfig.json which prevents tsc from recursively looking in subfolders. This change prevents calling tsconfig-glob package if there is no "filesGlob" property in tsconfig.json.