-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable in memory option in C++ backend #67
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: julian <[email protected]>
Some hacks needed to be done to support two different outputs due to templating Signed-off-by: julian <[email protected]>
Signed-off-by: julian <[email protected]>
BTW, I didn't add test for this one. But I wasn't sure about the best way of adding them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, great work! For now, just some wording suggestions. I'll get back to you about tests shortly.
Suggested by @ulupo Co-authored-by: Umberto Lupo <[email protected]>
Signed-off-by: julian <[email protected]>
@MonkeyBreaker should we also go ahead with this PR? |
I think that I should add a test, something simple. |
After we merge new github actions, I will add the missing test and hope that all test passes. |
Thanks @MonkeyBreaker!
I think that some draft version of this would be very helpful, but let's not spend too much time on this! |
This feature should be the main highlight of v0.4.6 :) |
Reference Issues/PRs
#61
What does this implement/fix? Explain your changes.
This PR integrates latest changes from
flagser
backend. In which the optionin_memory
is now available when computing homology.This options allows a tradeoff of using more memory in order to speed up computation.
Any other comments?
In order to support the
in_memory
data structure, I needed to duplicatepersistence_computer_t
part that manages the part to retrieve results. In my opinion it's not the best way of doing this, but due to how retrieving values from results was implemented inflagser
I cannot see how to do differently.If anyone has a better solution/approach, please let me know !
Quoting the author: