Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update countries-where-sms-authentication-is-supported.md #35864

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wyywwi
Copy link

@wyywwi wyywwi commented Jan 8, 2025

Added "regions" to the list description for clarity. Kept the front matter unchanged to avoid potential unintended impacts.

Why:

The list description previously lacked "regions", which could lead to confusion for some users. To improve clarity and accuracy, "regions" was added to the description.

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

The term "country" was updated to "country or region" in the section titled Supported countries for SMS authentication. The title was also updated. The front matter was left unchanged to prevent potential unintended impacts on indexing and browsing.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing.

Added "regions" to the list description for clarity.
Kept the front matter unchanged to avoid potential unintended impacts.
Copy link

welcome bot commented Jan 8, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/securing-your-account-with-two-factor-authentication-2fa/countries-where-sms-authentication-is-supported.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

818Nawaf

This comment was marked as spam.

@ASLE90

This comment was marked as spam.

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Jan 9, 2025
@nguyenalex836
Copy link
Contributor

@wyywwi Thanks so much for opening a PR! I'll get this triaged for review ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants