Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread configurable trustroot resync period to bundle trustroot func #171

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

malancas
Copy link
Contributor

@malancas malancas commented Jun 25, 2024

Allow the trustroot resync period flag value to be used by the tuf.GetTrustedRoot function, which currently uses a hardcoded resync period of 24 hours.

pkg/reconciler/trustroot/controller.go Show resolved Hide resolved
pkg/tuf/repo.go Show resolved Hide resolved
@malancas malancas marked this pull request as ready for review June 26, 2024 17:52
@malancas malancas requested review from steiza and a team as code owners June 26, 2024 17:52
Copy link
Collaborator

@codysoyland codysoyland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@malancas malancas merged commit 25aa6e7 into release Jun 26, 2024
67 of 69 checks passed
@malancas malancas deleted the configurable-trustroot-sync-period branch June 26, 2024 20:45
codysoyland pushed a commit that referenced this pull request Jul 9, 2024
…171)

* move trustroot resync period configration to different package

Signed-off-by: Meredith Lancaster <[email protected]>

* add license

Signed-off-by: Meredith Lancaster <[email protected]>

* comment

Signed-off-by: Meredith Lancaster <[email protected]>

* rename files

Signed-off-by: Meredith Lancaster <[email protected]>

---------

Signed-off-by: Meredith Lancaster <[email protected]>
codysoyland pushed a commit that referenced this pull request Sep 16, 2024
…171)

* move trustroot resync period configration to different package

Signed-off-by: Meredith Lancaster <[email protected]>

* add license

Signed-off-by: Meredith Lancaster <[email protected]>

* comment

Signed-off-by: Meredith Lancaster <[email protected]>

* rename files

Signed-off-by: Meredith Lancaster <[email protected]>

---------

Signed-off-by: Meredith Lancaster <[email protected]>
codysoyland pushed a commit that referenced this pull request Oct 10, 2024
…171)

* move trustroot resync period configration to different package

Signed-off-by: Meredith Lancaster <[email protected]>

* add license

Signed-off-by: Meredith Lancaster <[email protected]>

* comment

Signed-off-by: Meredith Lancaster <[email protected]>

* rename files

Signed-off-by: Meredith Lancaster <[email protected]>

---------

Signed-off-by: Meredith Lancaster <[email protected]>
codysoyland pushed a commit that referenced this pull request Nov 18, 2024
…171)

* move trustroot resync period configration to different package

Signed-off-by: Meredith Lancaster <[email protected]>

* add license

Signed-off-by: Meredith Lancaster <[email protected]>

* comment

Signed-off-by: Meredith Lancaster <[email protected]>

* rename files

Signed-off-by: Meredith Lancaster <[email protected]>

---------

Signed-off-by: Meredith Lancaster <[email protected]>
codysoyland pushed a commit that referenced this pull request Jan 7, 2025
…171)

* move trustroot resync period configration to different package

Signed-off-by: Meredith Lancaster <[email protected]>

* add license

Signed-off-by: Meredith Lancaster <[email protected]>

* comment

Signed-off-by: Meredith Lancaster <[email protected]>

* rename files

Signed-off-by: Meredith Lancaster <[email protected]>

---------

Signed-off-by: Meredith Lancaster <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants