Add signatureFormat in the conversion so that alpha1 and beta1 can be used #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @GregoireW! |
codysoyland
pushed a commit
that referenced
this pull request
Jul 9, 2024
codysoyland
pushed a commit
that referenced
this pull request
Sep 16, 2024
codysoyland
pushed a commit
that referenced
this pull request
Oct 10, 2024
codysoyland
pushed a commit
that referenced
this pull request
Nov 18, 2024
codysoyland
pushed a commit
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, you cannot create a beta1 version of the clusterimagepolicies.policy.sigstore.dev for github bundle validation. ( SignatureFormat would revert to an empty value ).
And worst, if you "kubectl edit" a clusterimagepolicies kubernetes would transform the alpha1 to beta1 for you to edit and transform back beta1 to alpha1 to store. It means the signatureFormat is lost and you can have something working, editing a label and oups nothing is working anymore