Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend join order badness RA parser #3051

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

kaspersv
Copy link
Contributor

@kaspersv kaspersv commented Nov 3, 2023

To improve readability of RA names, we will soon start using an extended character set for RA names. Quoting using backticks will be used to support pretty-printing and parsing of identifiers with extended characters. This PR extends the join-order evaluator log processor's RA parsing with support for quoted identifiers and brings it in line with the DCA join-order badness RA parser (see referenced PR below).

This PR should have no user visible effect until we start using quoted RA names with extended characters in evaluator logs. I've manually verified that we can still process existing evaluator logs and an evaluator log generated with a pre-release CLI that generates quoted identifiers.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@kaspersv kaspersv marked this pull request as ready for review November 3, 2023 09:18
@kaspersv kaspersv requested a review from a team as a code owner November 3, 2023 09:18
@kaspersv
Copy link
Contributor Author

kaspersv commented Nov 3, 2023

@dbartol would you be able to review this PR? It looks like you worked on the initial VS Code join order badness implementation.

@kaspersv kaspersv requested review from dbartol and removed request for dbartol November 3, 2023 15:09
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM and matches what we now do on DCA.

I'll let @github/codeql-vscode-reviewers determine what the right process for getting this merged is.

@kaspersv
Copy link
Contributor Author

kaspersv commented Nov 6, 2023

@github/codeql-vscode-reviewers Any objections to me merging this PR?

@kaspersv kaspersv merged commit 1fa7a93 into main Nov 6, 2023
25 checks passed
@kaspersv kaspersv deleted the kaspersv/parse-quoted-ra-idents branch November 6, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants