Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with scoping in let assert #4198

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

GearsDatapacks
Copy link
Member

Fixes #4195
This PR fixes the scoping issue by analysing the panic message before bringing the variable binding into scope.

@GearsDatapacks GearsDatapacks marked this pull request as draft January 25, 2025 00:21
@GearsDatapacks GearsDatapacks marked this pull request as ready for review January 25, 2025 10:21
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@lpil lpil merged commit 20d440b into gleam-lang:main Jan 25, 2025
12 checks passed
@GearsDatapacks GearsDatapacks deleted the fix-let-scoping branch January 25, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unbound variable getting passed the compiler
2 participants