fix: Expose the prefer-const-values Typescript language setting via CLI #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriswest
changed the title
|
@dvdsgl @schani (or any other maintainer), is there any chance of getting this one-line correction merged? The Linux Foundation/FINOS' FDC3 Standard project uses quicktype to generate Typescript interfaces as part of its build pipeline and we're stuck with a manual process without this option (as const values resolved a problem for use in the generated TypeScript types - we found that single value string enums, the alternative to string consts in standardized messages, do not match the string values where actual typescript consts do). As we make use of quicktype for this, we're trying to contribute back on those things that we use. |
kriswest
added a commit
to finos/FDC3
that referenced
this pull request
Nov 13, 2023
...after quicktype merged PR glideapps/quicktype#2426
|
Many thanks @schani, our automation will be back up and running again shortly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2345
A previous PR (#2314) introduced the ability to generate const values in Typescript but didn't expose that option correctly for use through the CLI. This one-line PR exposes the option (which works a treat!)
@DanielBretzigheimer