Fee Automation #94
Fee Automation #94
Conversation
- Initial MultichainReader.sol, MultichainReaderUtils.sol and IOriginator.sol drafts - Updates to Keys.sol and Errors.sol to support MultichainReader.sol - EndpointV2Mock.sol for local hardhat testing (testing still needs to be configured)
contracts/error/Errors.sol
Outdated
| error ConfirmationsLengthMismatch(uint256 chainIdsLength, uint256 confirmationsLength); | ||
| error UnauthorizedOriginator(address originator); | ||
| error OriginatorCallFailed(bytes transactionCallData); | ||
| error OnlyPeer(uint32 eid, bytes32 sender); |
There was a problem hiding this comment.
use Errors.Unauthorized instead
There was a problem hiding this comment.
The first is our own error message, and given the concerns around originator.call(transactionCallData) it may no longer be necessary anyway. The second is another error using LayerZero naming but can also be changed on our end.
| function sendReadRequests( | ||
| MultichainReaderUtils.ReadRequestInputs[] calldata readRequestInputs, | ||
| MultichainReaderUtils.ExtraOptionsInputs calldata extraOptionsInputs | ||
| ) external payable returns (MessagingReceipt memory, bytes32, MultichainReaderUtils.ReceivedData memory) { |
There was a problem hiding this comment.
might make sense to have an onlyController modifier here
There was a problem hiding this comment.
Sorry, to clarify, is this referring to the setDelegate() function?
I was thinking of removing it as previously discussed, but perhaps a safer option would be to use a highly restrictive modifier like onlyController.
LayerZero responded to my questions around this on telegram saying that a delegate could be useful if faulty dvns need to be removed for example, even if other configuration changes aren't necessary.
There was a problem hiding this comment.
i'm referring to adding an onlyController modifier to sendReadRequests, because in lzReceive, the originator contract is called, and the originator contract would be validating that msg.sender is MultichainReader, so MultichainReader has some unique access to call potentially important contracts
so i think it would be safer to restrict access of who can call MultichainReader
- Updated MultichainReader.sol per PR comments and other minor updates - Updated Errors.sol per PR comments - Removed unused function from IOriginator.sol - Updated solidity version to 0.8.20 from 0.8.18 to support LayerZero imports
Proposed implementation using lzReduce() to simplify the lzRead flow and logic
No description provided.