fix: properly use iterators

go-faster · Dec 7, 2024 · 69d0d53 · 69d0d53
1 parent 67796ba
commit 69d0d53
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/cmd/chotel/main.go b/cmd/chotel/main.go
@@ -237,7 +237,7 @@ func (a *App) send(ctx context.Context, now time.Time) error {
 		OnResult: func(ctx context.Context, block proto.Block) error {
 			exported.TraceID = append(exported.TraceID, t.TraceID...)
 			exported.SpanID = append(exported.SpanID, t.SpanID...)
-			for _, r := range t.Rows() {
+			for r := range t.Rows() {
 				exported.ExportedAt.Append(now)
 				stub := tracetest.SpanStub{
 					SpanKind:  r.Kind,

diff --git a/internal/chstorage/querier_traces.go b/internal/chstorage/querier_traces.go
@@ -702,14 +702,14 @@ func getTraceQLAttributeColumns(attr traceql.Attribute) iter.Seq[string] {
 	switch attr.Scope {
 	case traceql.ScopeNone:
 		return func(yield func(string) bool) {
-			yield(colAttrs)
-			yield(colResource)
-			yield(colScope)
+			_ = yield(colAttrs) &&
+				yield(colResource) &&
+				yield(colScope)
 		}
 	case traceql.ScopeResource:
 		return func(yield func(string) bool) {
-			yield(colScope)
-			yield(colResource)
+			_ = yield(colScope) &&
+				yield(colResource)
 		}
 	case traceql.ScopeSpan:
 		return func(yield func(string) bool) {