fix(experiments): use getters to prevent toc/tou limitations #2015
+36
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the value of experiment flags were read from the environment during the
init()
function, making it impossible to programmatically enable or disable flags when usingtask
as a package (#2014). This patch makes all experiments getters that read from the environment at time of access, not at time of initialization.A more flexible solution might be to expose
experiments
to theExecutor
and allow values to be overridden directly.