Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experiments): use getters to prevent toc/tou limitations #2015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rektdeckard
Copy link

@rektdeckard rektdeckard commented Jan 23, 2025

Previously, the value of experiment flags were read from the environment during the init() function, making it impossible to programmatically enable or disable flags when using task as a package (#2014). This patch makes all experiments getters that read from the environment at time of access, not at time of initialization.

A more flexible solution might be to expose experiments to the Executor and allow values to be overridden directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant