Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yaml): add reopened action to default pull_request unmarshal #332

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Nov 6, 2023

Found a bug (?) where users were expecting a Vela pull request build to launch when they re-opened a pull request, much like there is one when a user opens a pull request.

If we are to support reopened as a pull_request action, I believe it should also be a default in this custom unmarshal value for pull_request.

@ecrupper ecrupper self-assigned this Nov 6, 2023
@ecrupper ecrupper requested a review from a team as a code owner November 6, 2023 22:43
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #332 (d5ba25d) into main (c4fc61a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files          62       62           
  Lines        6858     6859    +1     
=======================================
+ Hits         6608     6609    +1     
  Misses        181      181           
  Partials       69       69           
Files Coverage Δ
yaml/ruleset.go 100.00% <100.00%> (ø)

@ecrupper ecrupper merged commit ba41348 into main Nov 7, 2023
10 checks passed
@ecrupper ecrupper deleted the fix/yaml/pr-default-reopened branch November 7, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants