-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better type info everywhere #93302
base: master
Are you sure you want to change the base?
Conversation
I'm not sure about adding module dependencies to |
c18a68d
to
ab92a42
Compare
theres mono and regex module dependencies in core and i think its properly |
ab92a42
to
4c9f122
Compare
There absolutely are, what I meant was adding more, I'd say we might instead want to achieve this with adding functionality to core that can be implemented in modules, like adding them to |
4c9f122
to
2a09b60
Compare
2a09b60
to
f5a68bc
Compare
that makes sense,, i feel a bit silly for not immediately agreeing with u removed the dependancy on GDScript |
88f2ef3
to
e88164e
Compare
e88164e
to
fafb4e3
Compare
fafb4e3
to
3222f84
Compare
3222f84
to
eeaf5eb
Compare
eeaf5eb
to
acc03cb
Compare
acc03cb
to
e2c5856
Compare
its slightly common to see 'NativeType(AttachedScriptType)' in an error message
but not common enough
this kinda standardizes it to 1 method
get_full_type_name
and uses it in many places+also
ContainerTypeValidate::get_contained_type_name()
the exact format of the full type name is of course up for debate but what i came up with:
examples of complex type name results:
Button (CustomButton)
Button (res://ui/CustomButton.gd)
GDScript[PlayerController]
GDScript[res://common/GameData.gd]
Array[GDScript (PlayerController)]