Default to using specialized implementation for some builtins. #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_713762977
branch
3 times, most recently
from
4b74ed4 to
26f9bb8
Compare
Applies to !/@not_strictly_false/==/!=/@in. This avoids some of the overhead for function dispatch at the cost of duplicating a subset of that logic and restricting the ability to customize them. Note: the fast builtins assume heterogeneous equality behavior. If not enabled, the runtime will fall back to the provided equals functions, instead of the new builtins step. PiperOrigin-RevId: 717979767
copybara-service
bot
force-pushed
the
test_713762977
branch
from
26f9bb8 to
3aef50a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to using specialized implementation for some builtins.
Applies to !/@not_strictly_false/==/!=/@in.
This avoids some of the overhead for function dispatch at the cost of duplicating a subset of that logic and restricting the ability to customize them.
Note: the fast builtins assume heterogeneous equality behavior. If not enabled, the runtime will fall back to the provided equals functions, instead of the new builtins step.