Bug fix, ensures search bar is cleared and hidden on tab change and c…

…onnections removed (#132)
google · Sep 11, 2024 · 368a497 · 368a497
1 parent 1678664
commit 368a497
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/ui/command_tab_view.cpp b/ui/command_tab_view.cpp
@@ -147,6 +147,7 @@ void CommandTabView::OnSearchBarVisibilityChange(bool isHidden)
     if (isHidden)
     {
         m_search_bar->clearSearch();
+        m_search_bar->hide();
         m_search_trigger_button->show();
         DisconnectSearchBar();
     }

diff --git a/ui/main_window.cpp b/ui/main_window.cpp
@@ -1012,6 +1012,8 @@ void MainWindow::CreateShortcuts()
         m_event_search_bar->clearSearch();
         m_event_search_bar->hide();
         m_search_trigger_button->show();
+
+        DisconnectSearchBar();
     });
 
     // Overview Shortcut
@@ -1178,6 +1180,7 @@ void MainWindow::OnCommandBufferSearchBarVisibilityChange(bool isHidden)
     if (isHidden)
     {
         m_event_search_bar->clearSearch();
+        m_event_search_bar->hide();
         m_search_trigger_button->show();
 
         DisconnectSearchBar();
@@ -1195,6 +1198,11 @@ void MainWindow::OnTabViewChange()
         m_event_search_bar->clearSearch();
         m_event_search_bar->hide();
         m_search_trigger_button->show();
+        DisconnectSearchBar();
+    }
+    else if (currentIndex != m_command_view_tab_index)
+    {
+        m_command_tab_view->OnSearchBarVisibilityChange(true);
     }
 }