Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Keyboard shortcuts #128

Merged
merged 6 commits into from
Aug 24, 2024
Merged

Adds Keyboard shortcuts #128

merged 6 commits into from
Aug 24, 2024

Conversation

GrantComm
Copy link
Collaborator

Adds Shortcuts for navigating tabs and searching events and command buffers. There is also a menu item under 'Help' that lists out the new shortcuts.

Screenshot 2024-08-21 at 8 42 30 AM

@shanminchao
Copy link
Collaborator

shanminchao commented Aug 22, 2024

I'm getting build errors with this PR:

/usr/bin/ld: CMakeFiles/dive_ui.dir/shortcuts_window.cpp.o: in function `ShortcutsDialog::ShortcutsDialog(QWidget*)':
/usr/local/google/home/shanminchao/src/dive/ui/shortcuts_window.cpp:38:(.text+0x46): undefined reference to `vtable for ShortcutsDialog'
/usr/bin/ld: /usr/local/google/home/shanminchao/src/dive/ui/shortcuts_window.cpp:38:(.text+0x5b): undefined reference to `vtable for ShortcutsDialog'
collect2: error: ld returned 1 exit status
make[2]: *** [ui/CMakeFiles/dive_ui.dir/build.make:744: ui/dive] Error 1
make[1]: *** [CMakeFiles/Makefile2:10209: ui/CMakeFiles/dive_ui.dir/all] Error 2
make: *** [Makefile:166: all] Error 2

Could be something wrong with my build. I'll look into it.

Also, I just enabled the GitHub checks. Let's see if GitHub Actions also reports a build error...

@shanminchao
Copy link
Collaborator

shanminchao commented Aug 22, 2024

Could be something wrong with my build. I'll look into it.

Ok nevermind, it was an issue with my cmake. I solved it and am able to build now.

However, there are some weird Windows build errors as well as lint issues. If you don't have access to a Windows build machine and need help, let me know and I can try building it on my windows machine at home.

ui/shortcuts.h Outdated Show resolved Hide resolved
@GrantComm
Copy link
Collaborator Author

Could be something wrong with my build. I'll look into it.

Ok nevermind, it was an issue with my cmake. I solved it and am able to build now.

However, there are some weird Windows build errors as well as lint issues. If you don't have access to a Windows build machine and need help, let me know and I can try building it on my windows machine at home.

Yeah, I see it is failing the windows build. I don't have a windows machine, so when you have the time could you try running on yours?

@shanminchao
Copy link
Collaborator

Could be something wrong with my build. I'll look into it.

Ok nevermind, it was an issue with my cmake. I solved it and am able to build now.
However, there are some weird Windows build errors as well as lint issues. If you don't have access to a Windows build machine and need help, let me know and I can try building it on my windows machine at home.

Yeah, I see it is failing the windows build. I don't have a windows machine, so when you have the time could you try running on yours?

Looks like your recent commits fixed the Windows issue. I also verified that it builds on my Windows machine.

@GrantComm GrantComm merged commit 8287921 into google:main Aug 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants