Fix crash when dealing with IBs where m_skip==true #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a case where m_start_node_stack assumes that packets exist in every IB, which is obviously not true for IBs that are "skipped". No packets get pushed on that stack, and then it gets popped at the end of OnIbEnd(). This causes a crash later. Fixed by using the m_new_ib_start flag to determine if any packets were pushed onto the stack, and not doing any of the usual things if nothing is pushed.
wangra-google
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a case where m_start_node_stack assumes that packets exist in every IB, which is obviously not true for IBs that are "skipped". No packets get pushed on that stack, and then it gets popped at the end of OnIbEnd(). This causes a crash later. Fixed by using the m_new_ib_start flag to determine if any packets were pushed onto the stack, and not doing any of the usual things if nothing is pushed.