Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables shader disassembly on Windows/MSVC #136

Merged
merged 14 commits into from
Oct 21, 2024
Merged

Conversation

GrantComm
Copy link
Collaborator

Shader disassembly relies on mesa generated code (ir3-isa.c) that MSVC refused to compile because it had zero size arrays. This change checks ensures there are no zero sized arrays and adds compile checks for msvc

@GrantComm GrantComm marked this pull request as ready for review October 9, 2024 17:16
@wangra-google
Copy link
Collaborator

wangra-google commented Oct 9, 2024

a general comment here: we need to add // GOOGLE: <reason for the change> when we make any change on any file in the mesa folder. The reason is that we might need to integrate the new versions from mesa in the future, it would be very difficult for integration if we do not put comments on our local changes. (This also means we need to minimize the changes in the files in the mesa folder as much as possible)

wangra-google
wangra-google previously approved these changes Oct 17, 2024
@wangra-google
Copy link
Collaborator

wangra-google commented Oct 17, 2024

strange that i keep having following building errors after applying this PR (having this error in both Debug and Release):
image

@wangra-google
Copy link
Collaborator

strange that i keep having following building errors after applying this PR (having this error in both Debug and Release): image

i tried another pc, no such error. must be something strange locally on that pc.

@GrantComm GrantComm requested a review from RenfengLiu October 18, 2024 18:32
@GrantComm GrantComm merged commit 002ffe5 into google:main Oct 21, 2024
7 checks passed
@GrantComm GrantComm removed the request for review from bjoeris October 21, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants