Adds Gfxr capture through dive cli #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrantComm
force-pushed
the
gfxr_capture_cli
branch
from
4447dcc to
9e8d8fe
Compare
GrantComm
force-pushed
the
gfxr_capture_cli
branch
from
9e8d8fe to
62ed845
Compare
RenfengLiu
reviewed
Dec 5, 2024
RenfengLiu
reviewed
Dec 5, 2024
wangra-google
previously approved these changes
Dec 6, 2024
GrantComm
force-pushed
the
gfxr_capture_cli
branch
from
aa11dda to
8b540a1
Compare
wangra-google
previously approved these changes
Dec 9, 2024
RenfengLiu
reviewed
Dec 9, 2024
RenfengLiu
reviewed
Dec 9, 2024
GrantComm
force-pushed
the
gfxr_capture_cli
branch
from
2265801 to
4e6bf13
Compare
RenfengLiu
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to perform a gfxr capture from the dive cli.
To perform a gfxr capture the gfxr_capture command must be used. Values for the device architecture, frame or frame range, and name of the directory containing the file that is saved on the device are set with flags. The following is an example:
./dive_client_cli --device localhost:40695 --command gfxr_capture --package com.google.android.filament.hellotriangle --type vulkan --device_architecture arm64-v8a --gfxr_capture_file_dir gfxr_triangle_captures --frame_range 1-3