Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Optimizations #156

Merged
merged 3 commits into from
Jan 11, 2025
Merged

Additional Optimizations #156

merged 3 commits into from
Jan 11, 2025

Conversation

shanminchao
Copy link
Collaborator

@shanminchao shanminchao commented Jan 8, 2025 •
edited
Loading

This PR covers the following optimizations:

  • Deferred shader loading, which for a particularly bad capture saves about 15-20s load time (from a previous high of 72s to 56s, for example)
  • Pre-reserve some vectors heavily used during command hierarchy construction. This saves about a couple of seconds from the load time, often lost in the noise

This PR also includes an assert fix when selecting the submit node.

@shanminchao shanminchao force-pushed the optimization branch 4 times, most recently from b04000e to 321a89c Compare January 8, 2025 22:01
@shanminchao shanminchao force-pushed the optimization branch 3 times, most recently from d83d26b to e3e0dfd Compare January 10, 2025 23:33
@shanminchao shanminchao merged commit a87e6c1 into google:main Jan 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangra-google wangra-google wangra-google approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanminchao @wangra-google