Show IB packets as children of INDIRECT_BUFFER packet #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The next step is to apply these changes to the set_draw_state packet. That part isn't done yet in this PR. |
shanminchao
force-pushed
the
ib_subpacket
branch
3 times, most recently
from
7cb5648 to
a3f5cd3
Compare
this is really cool! :D |
shanminchao
force-pushed
the
ib_subpacket
branch
2 times, most recently
from
ce3b838 to
d21a659
Compare
shanminchao
force-pushed
the
ib_subpacket
branch
from
d21a659 to
d26a62b
Compare
wangra-google
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts all IB packet nodes as children of the INDIRECT_BUFFER packet, and introduces an IB-Level column.
This makes it significantly easier to see the structure of the IBs at-a-glance, and allows for the collapsing of entire IBs by clicking on the arrow next to the INDIRECT_BUFFER packet.
The changes are non-trivial since it required modifying some underlying assumptions (e.g. can now have shared packets as children of other shared packets)