RTL indent support #427
Open
RTL indent support #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahimelaradi
commented
Sep 18, 2022
| @@ -6,3 +6,4 @@ | |||
| Google Inc. | |||
| Abhijeeth Padarthi <[email protected]> | |||
| Alex Li <[email protected]> | |||
| Ibrahim Elaradi <[email protected]> | |||
There was a problem hiding this comment.
Not sure if this is needed, just going according to the contribution guidelines here, I can remove it if it's needed since the change is trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed NodeWidget's Padding (responsible for indentation) to use EdgeInsetsDirectional.start instead of EdgeInsets.left to support RTL layouts.
Related Issues
Had the issue when using the package myself, no reported issues when I looked for them
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.flutter testpass.flutter analyzedoes not report any problems on my PR.