Ability added to use custom icons along with default icons in Node Le… #451
Conversation
|
Please see my comment on #447. Do not keep filing new PRs and closing them if you encounter a problem. |
|
@jamesderlin Sorry for that bro. this is finally I have created with no issues. I will delete rest of the previous. |
|
@jamesderlin I am very sorry to do that, actually it was my first time to make a PR on any of the plugin repository. I just was curious about it. Kindly delete the unwanted PR if you can or just decline them. Thank you for your support! |
|
@jamesderlin And why so many PR's ? aren't you guys taking the changes from other dev? By when my PR will be merged and reflect the changes on pub.dev ? any idea about this? |
|
If you mean why are there so many unmerged PRs, this repository is the home to multiple packages, each owned by different individuals. Those individuals are responsible for maintaining their packages and for merging PRs. Some of those individuals might have moved on to other projects. |
jamesderlin
added
the
p: flutter_simple_treeview
|
@jamesderlin Thanks for your quick response! I will contribute more features in the other packages too. and if it will be possible I will open the old PR by update code there, so that old PR's also been justified. Thanks for support. |
That would just be confusing. Just file new PRs for unrelated PRs from now on. |
| this.treeController}) | ||
| : nodes = copyTreeNodes(nodes), | ||
| /// This widget will be takes place of default icon when Node will not be in expanded state | ||
| final Widget? primaryIcon; |
| final Widget? primaryIcon; | ||
|
|
||
| /// This widget will be takes place of default icon when Node will be in expanded state | ||
| final Widget? secondaryIcon; |
| final Widget? primaryIcon; | ||
|
|
||
| /// This widget will be takes place of default icon when Node will be in expanded state | ||
| final Widget? secondaryIcon; |
There was a problem hiding this comment.
Here and in another one, make widget non-nullable and assign default value.
…ading.
Description
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.flutter testpass.flutter analyzedoes not report any problems on my PR.