[scrollable_positioned_list] Add ScrollController to be observed by Scrollbar #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello everyone!
I found that the solution proposed in the following PRs (#305, #445) is incorrect, since when scrolling long lists, primary and secondary _ListDisplayDetails are swapped. Therefore, you need to track both Scrollcontrollers.
Therefore, I propose the following fix: attach position primary ScrollController if positions is empty, and detach when changing ScrollControllers. I checked in my project, everything works correctly.
Related Issues
#273
#303
#278
#235
#175
#407
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.flutter test
pass.flutter analyze
does not report any problems on my PR.