PGO: Add make target to refresh profiles for PGO. #10656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
A friendly reminder that this PR had no activity for 120 days. |
This runs all benchmarks tagged as PGO-enabled, of which there is currently just one for simplicity (the ffmpeg benchmark). All other benchmarks are initially tagged out of PGO. I will send a different change to enroll other benchmarks in PGO. The make target runs each such benchmark and gathers profiles for each benchmark. Multiple profile files for multiple runs of the same benchmark are merged into one, then compared against the existing checked-in profile used for PGO builds (which right now doesn't exist). If such a profile doesn't exist or differs widely from the freshly-collected profile, then this new profile is copied into the repository. Such profiles are not used at all in builds yet, this is just the glue that keeps them fresh in the repo. PiperOrigin-RevId: 645209124
copybara-service
bot
force-pushed
the
test/cl645209124
branch
2 times, most recently
from
9f87d03 to
3f0c7cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PGO: Add make target to refresh profiles for PGO.
This runs all benchmarks tagged as PGO-enabled, of which there is
currently just one for simplicity (the ffmpeg benchmark). All other
benchmarks are initially tagged out of PGO. I will send a different
change to enroll other benchmarks in PGO.
The make target runs each such benchmark and gathers profiles for each
benchmark. Multiple profile files for multiple runs of the same benchmark
are merged into one, then compared against the existing checked-in profile
used for PGO builds (which right now doesn't exist). If such a profile
doesn't exist or differs widely from the freshly-collected profile, then
this new profile is copied into the repository.
Such profiles are not used at all in builds yet, this is just the glue
that keeps them fresh in the repo.