Fix minor compiler warnings that only show on Bazel.

- Explicitly invoke function being used in static_assert for arg validation. - Remove unused definitions in function traits test. Test: bazel test --cxxopt='-std=c++17' --repo_env=CC=clang ... PiperOrigin-RevId: 447758825 Change-Id: I92264d702522403498eb9f140506399548473c17
google · May 10, 2022 · fe35655 · fe35655
1 parent 94ce324
commit fe35655
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/implementation/method_selection.h b/implementation/method_selection.h
@@ -462,7 +462,7 @@ struct PermutationSelectionForArgs {
       typename MethodSelectionForArgs::template FindPermutation<Args...>;
 
   static constexpr bool kIsValidArgSet =
-      MethodSelectionForArgs::template ArgSetViable<Args...>;
+      MethodSelectionForArgs::template ArgSetViable<Args...>();
 
   using PermutationRef = PermutationRef<MethodSelectionForArgs, OverloadSelectionForArgs,
                                         PermutationForArgs>;

diff --git a/metaprogramming/function_traits_test.cc b/metaprogramming/function_traits_test.cc
@@ -124,4 +124,16 @@ TEST(FunctionTraits, MemberFunctions) {
           int>);
 }
 
+TEST(FunctionTraits,
+     UseFunctionsSoCompilerDoesntEmitWarningsAboutDiscardingThem) {
+  VFoo();
+  VFoo_I(1);
+  VFoo_II(1, 2);
+  VFoo_III(1, 2, 3);
+
+  VFoo_F(1.f);
+  VFoo_FF(1.f, 2.f);
+  VFoo_FFF(1.f, 2.f, 3.f);
+}
+
 }  // namespace