Inline mozc_win_build_target in build_defs.bzl
#1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows up to our previous commit [1], which intended to be a preparation to merge google#1109 to address google#1108. As another preparation this commit aims to simplify 'build_defs.bzl' by inlining 'mozc_win_build_target' into 'mozc_win32_cc_prod_binary'. There must be no change in the final artifacts. [1]: bc546b2
| @@ -382,6 +306,19 @@ def mozc_win32_cc_prod_binary( | |||
| visibility: optional. The visibility of the target. | |||
| **kwargs: other arguments passed to mozc_cc_binary. | |||
| """ | |||
| mandatory_target_compatible_with = [ | |||
There was a problem hiding this comment.
Please move this block (line 309 - 321) after mozc_cc_binary (line 322 - 336) to keep the consistency with the current implementation. It causes an error in my environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows up to our previous commit (bc546b2), which intended to be a preparation to merge #1109 to address #1108.
As another preparation this commit aims to simplify
build_defs.bzlby inliningmozc_win_build_targetintomozc_win32_cc_prod_binary.There must be no change in the final artifacts.
Issue IDs
mozc_tip32.dllbuilt with Bazel ismozc_tip.pdbrather thanmozc_tip32.dll.pdb#1108Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).