Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of .NET Extractors #355

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Implementation of .NET Extractors #355

merged 7 commits into from
Jan 10, 2025

Conversation

Octaviusss
Copy link
Contributor

Pull request for the .NET extractors.
Implemented:

  • Extractor implementation for package.config and .deps.json;
  • Unit test implementation for both extractors:
  • Integration of the extractors in the main tool;

vpasdf
vpasdf requested changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@vpasdf vpasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the highlighted issues

@Octaviusss Octaviusss mentioned this pull request Dec 19, 2024
Open
@Octaviusss Octaviusss requested a review from vpasdf December 19, 2024 15:01
vpasdf
vpasdf requested changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@vpasdf vpasdf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same as in #357)

Usually each result type of plugins has their own metadata struct. This is used in some use cases of Scalibr to distinguish result types

So you either add a metadata proto for .net. Then you need to update proto.go and scanresult proto. This is used in some programs to differentiate different result types. It's also recommended to have all necessary information in metadata for matching.

Or you don't, then that change is not required.

@Octaviusss Octaviusss requested a review from vpasdf December 20, 2024 10:22
@Octaviusss Octaviusss requested a review from vpasdf January 8, 2025 09:19
@Octaviusss Octaviusss requested a review from vpasdf January 10, 2025 16:40
@copybara-service copybara-service bot merged commit 032e218 into google:main Jan 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpasdf vpasdf vpasdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Octaviusss @vpasdf