Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of Nix extractor. #356

Closed
wants to merge 11 commits into from
Closed

Implementation of Nix extractor. #356

wants to merge 11 commits into from

Conversation

brnpl
Copy link
Contributor

@brnpl brnpl commented Dec 19, 2024

Pull request for the Nix package manager extractor.

Implemented:

  • Extractor implementation;
  • Unit test implementation;
  • Integrated extractor in the main tool;

vpasdf
vpasdf requested changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@vpasdf vpasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the highlighted issues

@brnpl brnpl requested a review from vpasdf January 9, 2025 13:31
@erikvarga
Copy link
Collaborator

Can you sync this branch with main? There are some merge conflicts that block merging

@brnpl brnpl requested a review from vpasdf January 13, 2025 14:23
@erikvarga
Copy link
Collaborator

The code doesn't seem to build right now:

Error: binary/proto/proto_test.go:563:22: too many arguments in call to nix.New
	have (unknown type)
	want ()

@brnpl brnpl requested a review from erikvarga January 16, 2025 11:12
copybara-service bot pushed a commit that referenced this pull request Jan 16, 2025
@copybara-github
Merge pull request #356 from mindedsecurity:extractor_nix
2974dcd 
PiperOrigin-RevId: 716185111
@erikvarga
Copy link
Collaborator

Merged in 2974dcd

@erikvarga erikvarga closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpasdf vpasdf Awaiting requested review from vpasdf

@erikvarga erikvarga Awaiting requested review from erikvarga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brnpl @erikvarga @vpasdf