Implementation of kernel module extractor. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvarga
reviewed
Jan 9, 2025
|
Looks like some files changed upstream since this PR got created to you'll have to resolve some merge conflicts |
erikvarga
reviewed
Jan 9, 2025
erikvarga
reviewed
Jan 10, 2025
|
|
||
| // Sections are delimited by null bytes (\x00) | ||
| for _, line := range bytes.Split(sectionData, []byte{'\x00'}) { | ||
|
|
There was a problem hiding this comment.
Fix linter error: module.go:186:65: unnecessary leading newline (whitespace)
| @@ -54,6 +54,14 @@ type Config struct { | |||
| MaxFileSizeBytes int64 | |||
| } | |||
|
|
|||
| type ModuleMetadata struct { | |||
There was a problem hiding this comment.
Why not reuse the Metadata struct from metadata.go? And then you can just pass the metadata struct to the inventory initialization directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the kernel module extractor.
Implemented: