Skip to content

Commit

Permalink
Introduce rocm-only tag and remove if_rocm_is_configured
Browse files Browse the repository at this point in the history
This replaces all `if_rocm_is_configured` guards in `stream_executor/rocm/...` with a filtering tag `rocm-only`. The CUDA build on the CI gets adjusted to skip those targets.

This uncovered some additional problems that get fixed as well:

- A wrong library name for the hipfft library in the Bazel CUDA configuration
- A wrong test case in the RocmVersionParser test that so far has not been running anywhere.
- Missing tags for the platform alias targets in `stream_executor/BUILD`

PiperOrigin-RevId: 678548961
  • Loading branch information
beckerhe authored and copybara-github committed Sep 25, 2024
1 parent 8c1310a commit e7dc77f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion third_party/gpus/rocm_configure.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ def _create_dummy_repository(repository_ctx):
"%{hipblas_lib}": _lib_name("hipblas"),
"%{miopen_lib}": _lib_name("miopen"),
"%{rccl_lib}": _lib_name("rccl"),
"%{hipfft_or_rocfft}": _lib_name("hipfft"),
"%{hipfft_or_rocfft}": "hipfft",
"%{hipfft_or_rocfft_lib}": _lib_name("hipfft"),
"%{hiprand_lib}": _lib_name("hiprand"),
"%{hipsparse_lib}": _lib_name("hipsparse"),
Expand Down

0 comments on commit e7dc77f

Please sign in to comment.