PR #21022: [XLA:CPU][oneDNN] Modify addend shape for small Convolution + Bias contraction #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…n + Bias contraction Imported from GitHub PR openxla/xla#21022 For small constant biases, XLA may perform constant folding, which can alter the shape of the bias passed to oneDNN. This PR removes any extraneous trivial dimensions from the bias that is passed to the oneDNN library. It also adds a test in all applicable dtypes to test the functionality. Copybara import of the project: -- 5ce5ba690d5acd1ebedca1484483639b2f3b0be1 by Akhil Goel <[email protected]>: Modify conv bias shape Merging this change closes #21022 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#21022 from Intel-tensorflow:akhil/conv_bias_fix 5ce5ba690d5acd1ebedca1484483639b2f3b0be1 PiperOrigin-RevId: 713098378
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #21022: [XLA:CPU][oneDNN] Modify addend shape for small Convolution + Bias contraction
Imported from GitHub PR openxla/xla#21022
For small constant biases, XLA may perform constant folding, which can alter the shape of the bias passed to oneDNN. This PR removes any extraneous trivial dimensions from the bias that is passed to the oneDNN library. It also adds a test in all applicable dtypes to test the functionality.
Copybara import of the project:
--
5ce5ba690d5acd1ebedca1484483639b2f3b0be1 by Akhil Goel [email protected]:
Modify conv bias shape
Merging this change closes #21022
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#21022 from Intel-tensorflow:akhil/conv_bias_fix 5ce5ba690d5acd1ebedca1484483639b2f3b0be1