Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate react-scripts to vite #696
base: master
Are you sure you want to change the base?
Migrate react-scripts to vite #696
Changes from all commits
bc896fa
289f100
96d09ef
a488460
45821b4
7a778b5
1ec8b23
1200f7c
560e3d9
122ef6a
1a5ca1f
8596883
df5dd66
d36a476
921a488
b2b7820
bb6292b
6ec7e0b
10f2b73
68e54d8
011160f
4d5aabe
df9a000
1d30cd6
dbed184
0e4cf73
8f4982e
932a521
f1ff3f2
71709db
57383cc
f25df9b
70c8900
a055be0
3eb2848
d8b1e9f
23e5fde
5fb3854
8d613bc
53f5ced
e2c5fa0
4952391
adf75a4
decfd41
daecf32
4d0f9bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this dep used somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dep shouldn't be needed, base64 encoding/decoding can be done natively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really the way to react to changes in the state, it there a native way in redux to subscribe to changes in the state and do stuff? Doing this in react seems weird, and having the global state besides redux store (the websocket store varibale in this case, or reconnectTimeoutId in the auth-actions.ts) seems weird to. The redux actions shouldn't have side effects with other global variables.