feat(gke): Handle hyperdisk balanced volumes #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First attempt at handling hyperdisk balanced volumes. The primary goal was to update the pricing map logic in such a way that would parse of hyperdisks balanced and include only the cost of capacity. Hyperdisk Balanced pricing is done in such a way that if you don't configure IOPS and Throughput, you use a free tier. In the future IOPS, Throughput, and High Availability costs need to be saved and calculated as well.
jjo
approved these changes
Nov 1, 2024
Pokom
added a commit
that referenced
this pull request
Nov 4, 2024
In #344, deprecated code was discovered which led to some confusion. It wasn't clear exactly how to remove the deprecated code and ensure tests were still functioning. 1. Rename `GeneratePricingMap` to `ParseSkus` 2. Update `ParseSkus` to be a receiver method on PricingMaps 3. Update `pricingMap.Populate` to return the result of ParseSkus 4. Update pricing map tests to call ParseSkus instead
Pokom
added a commit
that referenced
this pull request
Nov 6, 2024
In #344, deprecated code was discovered which led to some confusion. It wasn't clear exactly how to remove the deprecated code and ensure tests were still functioning. 1. Rename `GeneratePricingMap` to `ParseSkus` 2. Update `ParseSkus` to be a receiver method on PricingMaps 3. Update `pricingMap.Populate` to return the result of ParseSkus 4. Update pricing map tests to call ParseSkus instead
Pokom
added a commit
that referenced
this pull request
Nov 6, 2024
In #344, deprecated code was discovered which led to some confusion. It wasn't clear exactly how to remove the deprecated code and ensure tests were still functioning. 1. Rename `GeneratePricingMap` to `ParseSkus` 2. Update `ParseSkus` to be a receiver method on PricingMaps 3. Update `pricingMap.Populate` to return the result of ParseSkus 4. Update pricing map tests to call ParseSkus instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at handling hyperdisk balanced volumes. The primary goal was to update the pricing map logic in such a way that would parse of hyperdisks balanced and include only the cost of capacity. Hyperdisk Balanced pricing is done in such a way that if you don't configure IOPS and Throughput, you use a free tier.
In the future IOPS, Throughput, and High Availability costs need to be saved and calculated as well.